Shell May Cry: A comprehensive rework of synthetics. #20721
Conversation
…finish sorting the new organs, diagnostics update
NonQueueingMatt
added
⚠ High Risk
NonQueueingMatt
requested review from
Arrow768,
JohnWildkins and
DreamySkrell
as code owners
github-actions
bot
added
🗺️ Mapping - Away Ship/Away Site
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| @@ -1867,6 +1872,10 @@ | |||
| return 0 | |||
|
|
|||
| /mob/living/carbon/human/proc/can_drink(var/obj/item/I) | |||
There was a problem hiding this comment.
Adding the check for the reactor right at the start and returning TRUE, prevents the other checks from running (i.e. if the IPC has a mouth and if the mouth is covered)
There was a problem hiding this comment.
intended as baselines and etc don't have a mouth and thus cannot eat
| @@ -188,6 +188,11 @@ | |||
| var/obj/item/organ/internal/stomach/stomach = internal_organs_by_name[BP_STOMACH] | |||
| if(stomach) | |||
| return stomach.ingested | |||
|
|
|||
| if(should_have_organ(BP_REACTOR)) | |||
There was a problem hiding this comment.
Have you accounted for the chemical reactions that should/should not occur if IPCs ingest reagents?
There was a problem hiding this comment.
what reactions should not occur? struggling to think of any
if you eat water and potassium you should still explode as an ipc, no?
| /obj/item/organ/internal/machine/internal_storage | ||
| name = "internal storage system" | ||
| desc = "A simple internal casing used by G2 frames for internal storage." | ||
| organ_tag = BP_INTERNAL_STORAGE | ||
| parent_organ = BP_GROIN | ||
|
|
||
| action_button_name = "Access Internal Storage" | ||
|
|
||
| /// The actual, physical storage item. | ||
| var/obj/item/storage/internal_storage/storage |
There was a problem hiding this comment.
If we add internal storage, there needs to be a accessible way for security to check if it is empty and possibly forcefully empty it.
There was a problem hiding this comment.
to forcefully remove it they can ask a roboticist to remove the organ
will add a way to open the organ once removed
| /singleton/synthetic_organ_preset/reactor/kinetic | ||
| name = "kinetic power generator" | ||
| desc = "A simple, but effective power generator that uses motion to generate power." | ||
|
|
||
| external_charge_multiplier = 0.5 | ||
| base_power_generation = 5 | ||
| power_supply_type = POWER_SUPPLY_KINETIC |
There was a problem hiding this comment.
This wont be possible, because it turns a IPC into a Perpetuum mobile
| action_button_name = "Access Internal Computer" | ||
|
|
||
| /// This frame's internal PDA. | ||
| var/obj/item/modular_computer/handheld/pda/synthetic_internal/internal_pda |
There was a problem hiding this comment.
Should the wireless access function be de-coupled from a internal PDA function?
- I´d assume a internal PDA to be much more common than a wireless access point to access various machinery.
-> If decoupled, there should also be a way to insert the ID card into the internal PDA (so you can access programs that require a inserted id)
-> If the ability to insert the ID into the internal PDA is added, the ability to (forcefully) remove it should also be added
There was a problem hiding this comment.
will put it on the to-do list, yeah
https://www.youtube.com/watch?v=9mPvZ96pHJI
A pull request commissioned by the Synthetic Lore Team to comprehensively rework synthetics (read: IPCs) and how they work in Aurora. The objective is to make IPCs as unique as possible from humans, upgrading the robotic feel and atmosphere, while also preserving a good sense of balance in-game.
Key features:
To-do: